From 9fe5771d44dd65ae5be12b7fd01b4b1b9639e711 Mon Sep 17 00:00:00 2001
From: Brenno de Winter <brennodewinter@users.noreply.github.com>
Date: Tue, 9 Jun 2026 20:34:55 +0200
Subject: [PATCH] Reflect clear-all-checklists in the open slide editor

The editor subtree is keyed on the deck revision and only re-reads its slide
when that revision changes. clearAllChecklists mutated the deck without
bumping the revision, so the currently selected slide's editor kept showing
its cached (still-checked) checkboxes even though the slide preview updated.

Add a bumpRevision flag to _mutate and use it for the deck-wide clear so the
editor remounts and reflects the cleared state.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 lib/state/deck_provider.dart | 17 +++++++++++++++--
 test/deck_provider_test.dart |  3 +++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/lib/state/deck_provider.dart b/lib/state/deck_provider.dart
index 81200dc..cd22457 100644
--- a/lib/state/deck_provider.dart
+++ b/lib/state/deck_provider.dart
@@ -346,7 +346,12 @@ class DeckNotifier extends StateNotifier<DeckState> {
         slides.add(s);
       }
     }
-    if (changed) _mutate(deck.copyWith(slides: slides));
+    // Bump de revisie zodat de editor van de geselecteerde slide remount en de
+    // uitgevinkte checkboxen ook in het invoerpaneel toont (niet alleen in de
+    // slidepreview).
+    if (changed) {
+      _mutate(deck.copyWith(slides: slides), bumpRevision: true);
+    }
   }
 
   // ── Zoeken & vervangen ─────────────────────────────────────────────────────
@@ -553,7 +558,14 @@ class DeckNotifier extends StateNotifier<DeckState> {
   /// binnen [_coalesceWindow] valt, wordt geen nieuwe ongedaan-stap aangemaakt
   /// (zodat typen niet per teken een aparte stap oplevert). Een [coalesceKey]
   /// van null markeert een losse, discrete stap.
-  void _mutate(Deck deck, {String? coalesceKey}) {
+  ///
+  /// Wanneer [bumpRevision] waar is, wordt de inhouds-revisie opgehoogd. Dat
+  /// dwingt de editor-subtree (die op `revision` is gesleuteld) om te remounten
+  /// en zijn velden opnieuw uit de slide te laden. Nodig bij deck-brede
+  /// bewerkingen die de huidige slide aanpassen zonder dat de editor zelf de
+  /// bron van de wijziging was (anders blijft de editor de oude, gecachte
+  /// waarden tonen).
+  void _mutate(Deck deck, {String? coalesceKey, bool bumpRevision = false}) {
     final previous = state.deck;
     if (previous != null) {
       final now = DateTime.now();
@@ -576,6 +588,7 @@ class DeckNotifier extends StateNotifier<DeckState> {
       isDirty: true,
       canUndo: _undoStack.isNotEmpty,
       canRedo: false,
+      revision: bumpRevision ? state.revision + 1 : null,
     );
   }
 }
diff --git a/test/deck_provider_test.dart b/test/deck_provider_test.dart
index e46335f..7c50c76 100644
--- a/test/deck_provider_test.dart
+++ b/test/deck_provider_test.dart
@@ -151,6 +151,7 @@ void main() {
     n.loadDeck(n.state.deck!.copyWith(slides: [s1, s2]));
 
     expect(n.checkedChecklistCount, 4);
+    final revisionBefore = n.state.revision;
 
     n.clearAllChecklists();
 
@@ -159,6 +160,8 @@ void main() {
     expect(out[0].bullets, ['[ ] Klaar', '\t[ ] Subklaar', '[ ] Open']);
     expect(out[1].bullets, ['[ ] Eerste kolom']);
     expect(out[1].bullets2, ['[ ] Tweede kolom', '[ ] Nog open']);
+    // Revision bumps so the open slide editor remounts and reflects the change.
+    expect(n.state.revision, greaterThan(revisionBefore));
   });
 
   test('clearAllChecklists is a no-op when nothing is checked', () {