LibreKAT/Ocideck
LibreKAT/Ocideck
Watch
4
0
Fork
You've already forked Ocideck
 1
Code Issues Pull requests Projects Releases 21 Packages Activity Actions

[Bug] Small style bug #1330

New issue
Closed
opened 2026-08-07 13:56:13 +00:00 by kwoot · 2 comments
kwoot commented 2026-08-07 13:56:13 +00:00
Copy link

Describe the bug
When enabling slide numbers their location is not as expected.

To reproduce
Steps to reproduce the behaviour:

  1. Go to Settings -> Presentation style
  2. Go to footer section
  3. Enter footer text
  4. choose footer location center
  5. Enable show page numbers ( bottom right)
  6. Notice the page numbers are not shown bottom right.
  7. Also the player controls overlap with the centered footer text.

Expected behaviour
That page numbers are located as promised, bottom right.

Screenshots / sample deck
image

Environment

  • OciDeck version:
  • OS and version:
  • Flutter version (flutter --version):
  • Single or dual screen (if presenter-related):

Additional context
Anything else that might help.

For security vulnerabilities, do not open a public issue — see
SECURITY.md.

**Describe the bug** When enabling slide numbers their location is not as expected. **To reproduce** Steps to reproduce the behaviour: 1. Go to Settings -> Presentation style 2. Go to footer section 3. Enter footer text 4. choose footer location center 4. Enable show page numbers ( bottom right) 5. Notice the page numbers are not shown bottom right. 6. Also the player controls overlap with the centered footer text. **Expected behaviour** That page numbers are located as promised, bottom right. **Screenshots / sample deck** ![image](/attachments/17d8c1ca-d355-4afc-916a-249d7fd14aea) **Environment** - OciDeck version: - OS and version: - Flutter version (`flutter --version`): - Single or dual screen (if presenter-related): **Additional context** Anything else that might help. > For **security vulnerabilities**, do not open a public issue — see > [SECURITY.md](../../SECURITY.md).
image.png
18 KiB
brenno commented 2026-08-07 14:11:42 +00:00
Owner
Copy link

Opgepakt. Tak: fix/page-numbers-bottom-right-1330. Verwachte reikwijdte: lib/widgets/slides/previews/overlays.dart (paginanummer altijd rechtsonder i.p.v. meeliftend met de footerpositie) en de overlap tussen een gecentreerde footer en de spelerbalk (lib/widgets/presentation/audience_controls_bar.dart). Regressietest in test/.

Opgepakt. Tak: fix/page-numbers-bottom-right-1330. Verwachte reikwijdte: lib/widgets/slides/previews/overlays.dart (paginanummer altijd rechtsonder i.p.v. meeliftend met de footerpositie) en de overlap tussen een gecentreerde footer en de spelerbalk (lib/widgets/presentation/audience_controls_bar.dart). Regressietest in test/.
brenno commented 2026-08-07 16:30:05 +00:00
Owner
Copy link

Fixed on main (commit 13f13610, PR #1333).

The page number was being drawn in the same row as the footer text, so it followed the footer position — with the footer centered it ended up in the middle instead of the corner. It now sits in the bottom-right independently of the footer position, matching the setting's "(bottom right)" label, and dodges left of a logo or TLP badge when one occupies that corner. Verified in the editor preview, fullscreen presentation and the PDF export, in light and dark, with regression tests.

On the second point (player controls overlapping the centered footer): the on-screen control bar is a semi-transparent bar that appears on mouse movement and fades after a few seconds, and it sits mostly in the letterbox below the slide. Moving the page number out of the center actually removes the worst of that overlap, so the control bar itself was left as is.

Thanks for the clear report and the screenshot — it made this easy to pin down.

Fixed on `main` (commit 13f13610, PR #1333). The page number was being drawn in the same row as the footer text, so it followed the footer *position* — with the footer centered it ended up in the middle instead of the corner. It now sits in the bottom-right independently of the footer position, matching the setting's "(bottom right)" label, and dodges left of a logo or TLP badge when one occupies that corner. Verified in the editor preview, fullscreen presentation and the PDF export, in light and dark, with regression tests. On the second point (player controls overlapping the centered footer): the on-screen control bar is a semi-transparent bar that appears on mouse movement and fades after a few seconds, and it sits mostly in the letterbox below the slide. Moving the page number out of the center actually removes the worst of that overlap, so the control bar itself was left as is. Thanks for the clear report and the screenshot — it made this easy to pin down.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.5.0
v0.4.10
v0.4.9
v0.4.8
v0.4.7
v0.4.6
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.0
v0.1.3
v0.1.2
v0.1.1
v0.1.0
archive/git-mirror
Labels
Clear labels   
accepted
Assessed and will be built

  
bug
Something is broken

  
declined
Assessed and will not be built

  
docs
Documentation only

  
duplicate
Already tracked elsewhere

  
enhancement
New feature or improvement request

  
good first issue
Small, self-contained, and a good place to start

  
in-progress
Someone is working on this right now. Do not start it in parallel.

  
needs-info
Waiting for the reporter

  
privacy
Personal data can leak. Handled before anything else.

  
security
A weakness someone could use. Handled before anything else.

  
triage
Awaiting assessment

No labels
accepted
bug
declined
docs
duplicate
enhancement
good first issue
in-progress
needs-info
privacy
security
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
LibreKAT/Ocideck#1330
No description provided.