[Bug] Buttons don't work #150

New issue

Closed

opened 2026-07-09 08:20:45 +00:00 by kwoot · 2 comments

kwoot commented

2026-07-09 08:20:45 +00:00

Describe the bug
In the settings page some buttons don't work.

To reproduce
Steps to reproduce the behaviour:

Go to settings
Set some stuff according to this screenshot.
Try to click a yellow button.

Expected behaviour
I expect a file selection popup to appear.

Screenshots / sample deck

Environment

OciDeck version: online using firefox 150.0.2 on Ubuntu
OS and version: local linux
Flutter version (flutter --version): dunno
Single or dual screen (if presenter-related): single

Additional context
Anything else that might help. Nope. Nada. Zilch.

For security vulnerabilities, do not open a public issue — see
SECURITY.md.

**Describe the bug** In the settings page some buttons don't work. **To reproduce** Steps to reproduce the behaviour: 1. Go to settings 2. Set some stuff according to this screenshot. 3. Try to click a yellow button. **Expected behaviour** I expect a file selection popup to appear. **Screenshots / sample deck** **Environment** - OciDeck version: online using firefox 150.0.2 on Ubuntu - OS and version: local linux - Flutter version (`flutter --version`): dunno - Single or dual screen (if presenter-related): single **Additional context** Anything else that might help. Nope. Nada. Zilch. > For **security vulnerabilities**, do not open a public issue — see > [SECURITY.md](../../SECURITY.md).

Screenshot from 2026-07-08 16-48-43.png

40 KiB

brenno commented

2026-07-09 08:31:49 +00:00

Owner

Was reported yesterday. Has been solved in the meantime and the fix has been rolled out to the web-demo.

brenno closed this issue

2026-07-09 08:31:50 +00:00

brenno referenced this issue

2026-07-22 08:47:41 +00:00

[Feature] Guard platform-gated file pickers so #150 cannot regress #505

brenno referenced this issue

2026-07-22 08:47:42 +00:00

[Bug] Logo picker is not platform-gated and yields an unusable path on web #506

brenno commented

2026-07-22 08:48:02 +00:00

Owner

Thanks for reporting this, and for including your environment — that made it easy to pin down.

You found a real bug. The yellow buttons you clicked call the operating system's native folder picker, and that picker simply doesn't exist inside a browser: no dialog, no error, just silence. The fix was to stop showing those buttons in the web demo at all — a folder on your own machine is something the browser can't reach, so a button promising one would always be lying. On the desktop version the buttons work as before. As mentioned above, the fix is already live in the web demo.

Coming back to this with two follow-ups your report turned up. First, nothing in our test gates currently prevents this class of bug from coming back — a newly added picker button without the platform check would pass every test, because the web code path never runs under our test setup. That is now #505. Second, while verifying we found one more button on the same settings page, the logo picker, with the same flaw on web; that is #506. Neither is fixed yet.

So the visible behaviour on web is, and will stay: fewer buttons than on desktop, rather than buttons that ignore you. That is deliberate — the web demo shows what a browser can honestly deliver, and everything involving your local folders belongs to the desktop app.

This issue stays closed, since the buttons you reported are fixed. If you still see a dead button after a reload, please reopen with a note on which one.

Thanks for reporting this, and for including your environment — that made it easy to pin down. You found a real bug. The yellow buttons you clicked call the operating system's native folder picker, and that picker simply doesn't exist inside a browser: no dialog, no error, just silence. The fix was to stop showing those buttons in the web demo at all — a folder on your own machine is something the browser can't reach, so a button promising one would always be lying. On the desktop version the buttons work as before. As mentioned above, the fix is already live in the web demo. Coming back to this with two follow-ups your report turned up. First, nothing in our test gates currently prevents this class of bug from coming back — a newly added picker button without the platform check would pass every test, because the web code path never runs under our test setup. That is now #505. Second, while verifying we found one more button on the same settings page, the logo picker, with the same flaw on web; that is #506. Neither is fixed yet. So the visible behaviour on web is, and will stay: fewer buttons than on desktop, rather than buttons that ignore you. That is deliberate — the web demo shows what a browser can honestly deliver, and everything involving your local folders belongs to the desktop app. This issue stays closed, since the buttons you reported are fixed. If you still see a dead button after a reload, please reopen with a note on which one.

brenno added the

bug

label

2026-07-22 08:48:02 +00:00

brenno referenced this issue

2026-07-22 10:32:10 +00:00

feat: bewaak dat een pad uit FilePicker achter een platformpoort staat #527

brenno referenced this issue from a commit

2026-07-22 10:32:12 +00:00

feat(poort): een pad uit FilePicker moet achter een platformpoort staan

brenno referenced this issue

2026-07-22 10:44:02 +00:00