encodeList/decodeList helper extraheren uit 4 model-klassen #2073

New issue

Closed

opened 2026-09-13 08:05:41 +00:00 by brenno · 0 comments

brenno commented

2026-09-13 08:05:41 +00:00

Owner

Probleem

Vier modelklassen hebben exact hetzelfde JSON-lijst-patroon: jsonEncode([for (final x in list) x.toJson()]) en een jsonDecode + .fromJson + filter.

Betrokken bestanden

Bestand	encodeList	decodeList
`models/library_folder.dart`	28-29	33-47
`models/recent_file.dart`	97-98	102-114
`models/checklist_template.dart`	95-96	100-113
`models/storage_connection.dart`	75-76	81-98

Voorbeeld (recent_file.dart regels 97-114):

static String encodeList(List<RecentFile> files) =>
    jsonEncode([for (final f in files) f.toJson()]);

static List<RecentFile> decodeList(String? json) {
  if (json == null || json.isEmpty) return const [];
  try {
    final decoded = jsonDecode(json);
    if (decoded is! List) return const [];
    return [
      for (final item in decoded)
        if (item is Map)
          RecentFile.fromJson(Map<String, Object?>.from(item)),
    ].where((f) => f.path.isNotEmpty).toList();
  } catch (e) {
    logWarning('RecentFile.decodeList: onleesbare recente-lijst', e);
    return const [];
  }
}

library_folder.dart regels 27-47 is nagenoeg identiek, alleen de klassenaam en filter verschillen.

Verschillen

De filter-callback verschilt per model: path.isNotEmpty, name.isNotEmpty, name.isNotEmpty || title.isNotEmpty, of fromJson kan null teruggeven bij StorageConnection.

Voorstel

Voeg een generieke helper toe, bijv. in utils/json_list_codec.dart:

String encodeList<T>(List<T> list, Map<String, Object?> Function(T) toJson) =>
    jsonEncode([for (final x in list) toJson(x)]);

List<T> decodeList<T>(
  String? json,
  T? Function(Map<String, Object?>) fromJson, {
  bool Function(T)? keep,
  String label = 'decodeList',
}) {
  if (json == null || json.isEmpty) return const [];
  try {
    final decoded = jsonDecode(json);
    if (decoded is! List) return const [];
    return [
      for (final item in decoded)
        if (item is Map)
          fromJson(Map<String, Object?>.from(item)),
    ].whereType<T>().where(keep ?? (_) => true).toList();
  } catch (e) {
    logWarning('$label: onleesbare lijst', e);
    return const [];
  }
}

Dit is een pure interne refactor zonder UI-impact.

Schatting

Per model ~10-15 regels, totaal ~35-50 regels.

Labels

duplicate, enhancement

## Probleem Vier modelklassen hebben exact hetzelfde JSON-lijst-patroon: `jsonEncode([for (final x in list) x.toJson()])` en een `jsonDecode` + `.fromJson` + filter. ## Betrokken bestanden | Bestand | encodeList | decodeList | |---|---|---| | `models/library_folder.dart` | 28-29 | 33-47 | | `models/recent_file.dart` | 97-98 | 102-114 | | `models/checklist_template.dart` | 95-96 | 100-113 | | `models/storage_connection.dart` | 75-76 | 81-98 | Voorbeeld (`recent_file.dart` regels 97-114): ```dart static String encodeList(List<RecentFile> files) => jsonEncode([for (final f in files) f.toJson()]); static List<RecentFile> decodeList(String? json) { if (json == null || json.isEmpty) return const []; try { final decoded = jsonDecode(json); if (decoded is! List) return const []; return [ for (final item in decoded) if (item is Map) RecentFile.fromJson(Map<String, Object?>.from(item)), ].where((f) => f.path.isNotEmpty).toList(); } catch (e) { logWarning('RecentFile.decodeList: onleesbare recente-lijst', e); return const []; } } ``` `library_folder.dart` regels 27-47 is nagenoeg identiek, alleen de klassenaam en filter verschillen. ## Verschillen De filter-callback verschilt per model: `path.isNotEmpty`, `name.isNotEmpty`, `name.isNotEmpty || title.isNotEmpty`, of `fromJson` kan null teruggeven bij `StorageConnection`. ## Voorstel Voeg een generieke helper toe, bijv. in `utils/json_list_codec.dart`: ```dart String encodeList<T>(List<T> list, Map<String, Object?> Function(T) toJson) => jsonEncode([for (final x in list) toJson(x)]); List<T> decodeList<T>( String? json, T? Function(Map<String, Object?>) fromJson, { bool Function(T)? keep, String label = 'decodeList', }) { if (json == null || json.isEmpty) return const []; try { final decoded = jsonDecode(json); if (decoded is! List) return const []; return [ for (final item in decoded) if (item is Map) fromJson(Map<String, Object?>.from(item)), ].whereType<T>().where(keep ?? (_) => true).toList(); } catch (e) { logWarning('$label: onleesbare lijst', e); return const []; } } ``` Dit is een pure interne refactor zonder UI-impact. ## Schatting Per model ~10-15 regels, totaal **~35-50 regels**. ## Labels duplicate, enhancement

brenno added the

enhancement

duplicate

labels

2026-09-13 08:05:41 +00:00

brenno referenced this issue from a commit

2026-09-13 10:05:59 +00:00

refactor: extraheer encodeList/decodeList naar json_list_codec.dart (#2073)

brenno referenced this issue

2026-09-13 10:06:07 +00:00

refactor: dupliceer-codes opruimen (13 issues) #2084

brenno referenced this issue from a commit