LibreKAT/Ocideck
LibreKAT/Ocideck
Watch
4
0
Fork
You've already forked Ocideck
 1
Code Issues Pull requests Projects Releases 25 Packages Activity Actions

_xmlEscape/_xmlAttr centraliseren (7+ kopieen in export-services) #2074

New issue
Closed
opened 2026-09-13 08:05:51 +00:00 by brenno · 0 comments
brenno commented 2026-09-13 08:05:51 +00:00
Owner
Copy link

Probleem

De helpers _xmlEscape en _xmlAttr staan letterlijk gekopieerd in 7+ export/conversie services. Ze doen HTML/XML entity escaping van &, <, >, ", '.

Alle voorkomens

Bestand Regels Opmerking
services/docx/markdown_to_docx.dart 662-667 exact
services/odt/markdown_to_odt.dart 549-554 exact
services/epub/markdown_to_xhtml.dart 470-475 exact
services/docx/document_docx_export.dart 821-822 alleen _xmlEscape
services/odt/document_odt_export.dart 383-384 alleen _xmlEscape
services/epub/document_epub_export.dart 383-384 alleen _xmlEscape
services/pptx/deck_pptx_export.dart 98-103, 108 _xmlAttr mist apos-escape
services/odp/deck_odp_export.dart 186-187 alleen _xmlEscape

De pptx-variant wijkt licht af (_xmlAttr mist de apostrophe-escape), wat een potentiele bug is.

Voorstel

Verplaats naar lib/utils/xml_escape.dart en importeer overal. Dit lost ook de pptx-inconsistentie op.

Schatting

~25-30 regels verwijderbaar.

Labels

duplicate, enhancement

## Probleem De helpers `_xmlEscape` en `_xmlAttr` staan letterlijk gekopieerd in 7+ export/conversie services. Ze doen HTML/XML entity escaping van `&`, `<`, `>`, `"`, `'`. ## Alle voorkomens | Bestand | Regels | Opmerking | |---|---|---| | `services/docx/markdown_to_docx.dart` | 662-667 | exact | | `services/odt/markdown_to_odt.dart` | 549-554 | exact | | `services/epub/markdown_to_xhtml.dart` | 470-475 | exact | | `services/docx/document_docx_export.dart` | 821-822 | alleen `_xmlEscape` | | `services/odt/document_odt_export.dart` | 383-384 | alleen `_xmlEscape` | | `services/epub/document_epub_export.dart` | 383-384 | alleen `_xmlEscape` | | `services/pptx/deck_pptx_export.dart` | 98-103, 108 | `_xmlAttr` mist apos-escape | | `services/odp/deck_odp_export.dart` | 186-187 | alleen `_xmlEscape` | De pptx-variant wijkt licht af (`_xmlAttr` mist de apostrophe-escape), wat een potentiele bug is. ## Voorstel Verplaats naar `lib/utils/xml_escape.dart` en importeer overal. Dit lost ook de pptx-inconsistentie op. ## Schatting ~25-30 regels verwijderbaar. ## Labels duplicate, enhancement
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.6.3
archive/matrix-collab
v0.6.2
v0.6.1
v0.6.0
v0.5.0
v0.4.10
v0.4.9
v0.4.8
v0.4.7
v0.4.6
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.6
v0.3.5
v0.3.4
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.0
v0.1.3
v0.1.2
v0.1.1
v0.1.0
archive/git-mirror
Labels
Clear labels   
accepted
Assessed and will be built

  
bug
Something is broken

  
declined
Assessed and will not be built

  
docs
Documentation only

  
duplicate
Already tracked elsewhere

  
enhancement
New feature or improvement request

  
good first issue
Small, self-contained, and a good place to start

  
in-progress
Someone is working on this right now. Do not start it in parallel.

  
needs-info
Waiting for the reporter

  
privacy
Personal data can leak. Handled before anything else.

  
security
A weakness someone could use. Handled before anything else.

  
triage
Awaiting assessment

No labels
accepted
bug
declined
docs
duplicate
enhancement
good first issue
in-progress
needs-info
privacy
security
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
LibreKAT/Ocideck#2074
No description provided.