[Docs] The SBOM is shipped with the web build only, not with every build #599
Labels
No labels
accepted
bug
declined
docs
duplicate
enhancement
good first issue
in-progress
needs-info
privacy
security
triage
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
LibreKAT/Ocideck#599
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found in the pre-publication claim audit.
The claim —
docs/SBOM.md:9: the SBOM is "checked into the repository, kept current by a staleness gate in the test suite … and shipped with every build";:165: "The SBOM travels with the product, not just the repository."Evidence: only
build-webdoes that.Makefile:687—build-web: deps-verify-offline sbom-verify…:696-697—mkdir -p build/web/sbompluscp sbom/*.Makefile:718,:724,:730(build-macos,build-windows,build-linux) run a bareflutter build— no SBOM copy, and not evensbom-verifyas a prerequisite.README.md:5calls OciDeck "A desktop application", so the three targets that do not carry the SBOM are the primary product.Second claim, same file:
docs/SBOM.md:52says the inventory "can never disagree with what is actually built". The build-SDK row is read from.tool-versions(tool/sbom_build.dart:665-684), sosbom/ocideck.cdx.jsonrecordssdk:flutter@3.44.6while the toolchain resolved in this checkout is 3.44.2. Nothing in the Makefile or the tests asserts that the running Flutter matches.tool-versions.Why this matters now: SBOM.md is explicitly aimed at CRA readers — the audience that will open
sbom/ocideck.cdx.jsonand compare it against a build. "Can never disagree with what is actually built" is falsifiable on the maintainer own machine today, and the "every build" claim is falsifiable by reading the Makefile.Proposal: say "shipped with the web build; desktop bundles carry it in the release artefact" (which
.github/workflows/release.yml:48-51does declare, though that workflow has never run). Replace the second claim with "derived from the files that pin the build (pubspec.lock,MANIFEST.json,.tool-versions) — a machine whose Flutter differs from.tool-versionsis not detected". Cheap code fix worth doing: addsbom-verifyas a prerequisite to the three desktop targets.Opgelost in #656 (gemerged).
make checkgroen op de gerebasede kop.