[Bug] DeckNotifier sits at exactly its class-size ceiling, 1307 of 1307 #630

New issue

Closed

opened 2026-07-22 16:21:56 +00:00 by brenno · 0 comments

brenno commented

2026-07-22 16:21:56 +00:00

Owner

Found in the pre-publication test review, measured empirically. Relates to #518 (structural debt) but filed separately so it can be closed on its own.

Evidence: in a throwaway worktree on clean HEAD, adding five empty methods to lib/state/deck_provider_auto.dart produces DeckNotifier: 1312 lines (ceiling 1307). HEAD therefore sits at the ceiling with zero headroom. This was also observed in the live working copy: thirteen lines of unrelated work from a parallel session turned make check-conventions red with 1319 lines (ceiling 1307).

The baseline has not been raised since 0e6fb84b, so the ratchet is holding — but the error message reads "or deliberately raise the line in classSizeBaseline", which is exactly what someone under time pressure will do.

Why this matters now: the first outside contribution that adds anything to the deck provider gets a red gate about class size that has nothing to do with their change, plus an invitation to widen the ratchet. At a public launch that is the shortest route from "good first impression" to "that baseline is only a number anyway".

Proposal: before launch, lift one coherent chunk of behaviour out of DeckNotifier — deck_provider_miauw.dart (23 lines) or deck_provider_ai.dart are candidates — into its own class or service, and lower the baseline to the new figure. Fifty lines of headroom is enough.

Found in the pre-publication test review, measured empirically. Relates to #518 (structural debt) but filed separately so it can be closed on its own. **Evidence:** in a throwaway worktree on clean HEAD, adding five empty methods to `lib/state/deck_provider_auto.dart` produces `DeckNotifier: 1312 lines (ceiling 1307)`. HEAD therefore sits at the ceiling with **zero** headroom. This was also observed in the live working copy: thirteen lines of unrelated work from a parallel session turned `make check-conventions` red with `1319 lines (ceiling 1307)`. The baseline has not been raised since `0e6fb84b`, so the ratchet is holding — but the error message reads "or deliberately raise the line in classSizeBaseline", which is exactly what someone under time pressure will do. **Why this matters now:** the first outside contribution that adds anything to the deck provider gets a red gate about class size that has nothing to do with their change, plus an invitation to widen the ratchet. At a public launch that is the shortest route from "good first impression" to "that baseline is only a number anyway". **Proposal:** before launch, lift one coherent chunk of behaviour out of `DeckNotifier` — `deck_provider_miauw.dart` (23 lines) or `deck_provider_ai.dart` are candidates — into its own class or service, and lower the baseline to the new figure. Fifty lines of headroom is enough.

brenno added the

bug

label

2026-07-22 16:21:56 +00:00

brenno referenced this issue from a commit

2026-07-22 17:58:58 +00:00

refactor(state): geef DeckNotifier lucht, en ruim drie kleine bugs op

brenno referenced this issue from a pull request that will close it,

2026-07-22 17:59:17 +00:00

refactor+fix: DeckNotifier krijgt lucht, plus twee opruimbugs (#630, #639, #637) #663

brenno closed this issue

2026-07-22 17:59:29 +00:00