LibreKAT/Ocideck
LibreKAT/Ocideck
Watch
4
0
Fork
You've already forked Ocideck
 3
Code Issues 46 Pull requests Projects Releases 39 Packages Activity Actions 1

refactor: consolideer vijf duplicaten + verlaag ratchet-baselines #1142

Closed
brenno wants to merge 0 commits from refactor/consolidatie-duplicaten into main
pull from: refactor/consolidatie-duplicaten
merge into: LibreKAT:main
Conversation 0 Commits - Files changed -
brenno commented 2026-08-02 20:49:46 +00:00
Owner
Copy link

Summary

  • ExtractionLimitException gedeeld via lib/utils/archive_limits.dart (was 2× gekopieerd)
  • Bestandsnaam-sanitizer gedeeld via lib/utils/safe_filename.dart (was 3× gekopieerd)
  • SSRF-pinning-recept gedeeld via lib/utils/pinned_http_client.dart (was 5× gekopieerd in cve, git, matrix, webdav, s3)
  • Image-resize-stap gedeeld via lib/utils/image_resize.dart (was 2× gekopieerd)
  • _validateBlockLines in markdown_validator.dart van 162 naar onder 150 regels via één _directiveValue-helper (de poort faalde)
  • Ratchet-baselines verlaagd naar de gemeten waarde (5 bestanden, 9 klasses, 4 methode-lengtes)

Bewaker-afweging (punt 3, SSRF-pinning): veiligheid staat op 1, en centraliseren van beveiligingslogica versterkt die hier — vijf kopieën die uit elkaar lopen is een groter risico dan één helper.

Test plan

  • make check volledig groen (8106 tests, 87.4% dekking)
  • make check-secrets schoon (gitleaks + trufflehog)
  • make sast schoon (semgrep, 0 findings)
  • make check-static alle poorten OK
  • network_sink_guard_test bijgewerkt voor nieuwe helper
  • source_map_coverage_test bijgewerkt voor 4 nieuwe bestanden

Generated with Devin

## Summary - **ExtractionLimitException** gedeeld via `lib/utils/archive_limits.dart` (was 2× gekopieerd) - **Bestandsnaam-sanitizer** gedeeld via `lib/utils/safe_filename.dart` (was 3× gekopieerd) - **SSRF-pinning-recept** gedeeld via `lib/utils/pinned_http_client.dart` (was 5× gekopieerd in cve, git, matrix, webdav, s3) - **Image-resize-stap** gedeeld via `lib/utils/image_resize.dart` (was 2× gekopieerd) - **`_validateBlockLines`** in `markdown_validator.dart` van 162 naar onder 150 regels via één `_directiveValue`-helper (de poort faalde) - **Ratchet-baselines** verlaagd naar de gemeten waarde (5 bestanden, 9 klasses, 4 methode-lengtes) Bewaker-afweging (punt 3, SSRF-pinning): veiligheid staat op 1, en centraliseren van beveiligingslogica versterkt die hier — vijf kopieën die uit elkaar lopen is een groter risico dan één helper. #### Test plan - [x] `make check` volledig groen (8106 tests, 87.4% dekking) - [x] `make check-secrets` schoon (gitleaks + trufflehog) - [x] `make sast` schoon (semgrep, 0 findings) - [x] `make check-static` alle poorten OK - [x] network_sink_guard_test bijgewerkt voor nieuwe helper - [x] source_map_coverage_test bijgewerkt voor 4 nieuwe bestanden Generated with [Devin](https://devin.ai)
brenno force-pushed refactor/consolidatie-duplicaten from 5d58bb7903
Some checks failed
scans / scans (pull_request) Has been cancelled
Details
static-gate / static-gate (pull_request) Has been cancelled
Details
to 5015466421
Some checks failed
scans / scans (pull_request) Has been cancelled
Details
static-gate / static-gate (pull_request) Has been cancelled
Details
2026-08-02 20:58:31 +00:00 Compare
brenno closed this pull request 2026-08-02 20:59:17 +00:00
Some checks failed
scans / scans (pull_request) Has been cancelled
Details
static-gate / static-gate (pull_request) Has been cancelled
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accepted
Assessed and will be built

  
bug
Something is broken

  
declined
Assessed and will not be built

  
docs
Documentation only

  
duplicate
Already tracked elsewhere

  
enhancement
New feature or improvement request

  
good first issue
Small, self-contained, and a good place to start

  
in-progress
Someone is working on this right now. Do not start it in parallel.

  
needs-info
Waiting for the reporter

  
privacy
Personal data can leak. Handled before anything else.

  
release-blocker
Must land before the next release. scripts/release_auto.sh refuses to start while this is open.

  
security
A weakness someone could use. Handled before anything else.

  
triage
Awaiting assessment

No labels
accepted
bug
declined
docs
duplicate
enhancement
good first issue
in-progress
needs-info
privacy
release-blocker
security
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
LibreKAT/Ocideck!1142
No description provided.