docs: PR-sjabloon wijst naar de bron van waarheid en vraagt naar de afweging #524

Merged

brenno merged 2 commits from fix/pr-template-talen-en-afweging into main 2026-07-22 10:17:19 +00:00

Conversation 0 Commits 2 Files changed 2 +86 -2

brenno commented 2026-07-22 10:17:17 +00:00

Owner

Copy link

Summary

The PR checklist named eight languages (nl/en/it/de/fr/es/fy/pap) while AppLocalizations.languageNames holds 32. A contributor ticking that box honestly shipped 24 languages short and had no way to know — a checklist that misleads rather than merely being incomplete. And nothing in the template ever asked the contributor to weigh the project's principles, even though the template is the only place an outside contributor sees.

Closes #510

Changes

• test/pr_template_consistency_test.dart — asserts the template enumerates no language codes, and that the trade-off item is present. It tests the absence of a list rather than its correctness, because a freshly written list rots the same way on the next language.
• The l10n item now points at make add-l10n SPEC=… and AppLocalizations.languageNames as the authoritative set.
• One new checklist item on the trade-off (format, storage, dependency, outgoing traffic, or a promise): which principle took precedence, why, and what would change my mind.
• The existing test item was sharpened rather than duplicated: a bug fix needs a test on the reported behaviour that was red once, or an explanation of what gate covers it instead. The issue warns that a checklist firing on every PR gets ticked unread, so this is a refinement of a line that already existed, not a fifth box.

Split red-then-green: the test commit fails on its own, the template commit turns it green. Also verified against a planted regression (re-adding nl/en/it/de makes it fail again).

Gates

• make check — green (86.3% coverage, per-file floor 0 below budget).
• make check-secrets / make sast — still red for the two pre-existing reasons filed as #522 and #521. Unrelated to this branch; nothing here touches lib/.

Principles

Touches a promise in the sense that it changes what we ask contributors to affirm — but it makes an existing claim true rather than adding a new one. No conflict to record.

## Summary The PR checklist named eight languages (`nl/en/it/de/fr/es/fy/pap`) while `AppLocalizations.languageNames` holds 32. A contributor ticking that box honestly shipped 24 languages short and had no way to know — a checklist that misleads rather than merely being incomplete. And nothing in the template ever asked the contributor to weigh the project's principles, even though the template is the only place an outside contributor sees. Closes #510 ## Changes - `test/pr_template_consistency_test.dart` — asserts the template enumerates **no** language codes, and that the trade-off item is present. It tests the *absence* of a list rather than its correctness, because a freshly written list rots the same way on the next language. - The l10n item now points at `make add-l10n SPEC=…` and `AppLocalizations.languageNames` as the authoritative set. - One new checklist item on the trade-off (format, storage, dependency, outgoing traffic, or a promise): which principle took precedence, why, and what would change my mind. - The existing test item was **sharpened rather than duplicated**: a bug fix needs a test on the reported behaviour that was red once, or an explanation of what gate covers it instead. The issue warns that a checklist firing on every PR gets ticked unread, so this is a refinement of a line that already existed, not a fifth box. Split red-then-green: the test commit fails on its own, the template commit turns it green. Also verified against a planted regression (re-adding `nl/en/it/de` makes it fail again). ## Gates - `make check` — green (86.3% coverage, per-file floor 0 below budget). - `make check-secrets` / `make sast` — still red for the two pre-existing reasons filed as #522 and #521. Unrelated to this branch; nothing here touches `lib/`. ## Principles Touches a promise in the sense that it changes what we ask contributors to affirm — but it makes an existing claim true rather than adding a new one. No conflict to record.

brenno added 2 commits 2026-07-22 10:17:17 +00:00

test(sjabloon): bewaak dat het PR-sjabloon geen talenlijst uitschrijft ... 050ce066ef

Het sjabloon noemde acht talen terwijl er 32 zijn. Wie dat vinkje eerlijk
aanzette, leverde 24 talen te weinig en kon dat niet weten — een
checklist die misleidt in plaats van alleen onvolledig te zijn.

De test toetst de afwezigheid van een opsomming, niet de juistheid ervan:
een verse lijst verrot bij de volgende taal precies zo. Staat bewust rood
tot de volgende commit.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

docs(sjabloon): wijs naar de bron van waarheid, en vraag naar de afweging ... e8a16d96c8

De talenlijst wordt een verwijzing naar make add-l10n en
AppLocalizations.languageNames, zodat hij niet opnieuw kan verouderen.

Daarnaast één regel die vraagt naar de afweging bij formaat, opslag, een
afhankelijkheid, uitgaand verkeer of een belofte. De poorten dekken wat
mechaniseerbaar is; de weging niet, en dit sjabloon is de enige plek waar
een bijdrager van buiten die vraag ooit ziet.

De bestaande testregel is aangescherpt in plaats van uitgebreid met een
nieuw vinkje: een checklist die overal afgaat wordt afgevinkt zonder
gelezen te worden.

Closes #510

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

brenno merged commit 5df7dd9406 into main 2026-07-22 10:17:19 +00:00

brenno referenced this pull request from a commit 2026-07-22 10:17:19 +00:00

Merge pull request 'docs: PR-sjabloon wijst naar de bron van waarheid en vraagt naar de afweging' (#524) from fix/pr-template-talen-en-afweging into main

brenno deleted branch fix/pr-template-talen-en-afweging 2026-07-22 10:17:19 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

accepted

Assessed and will be built

  

bug

Something is broken

  

declined

Assessed and will not be built

  

docs

Documentation only

  

duplicate

Already tracked elsewhere

  

enhancement

New feature or improvement request

  

good first issue

Small, self-contained, and a good place to start

  

in-progress

Someone is working on this right now. Do not start it in parallel.

  

needs-info

Waiting for the reporter

  

privacy

Personal data can leak. Handled before anything else.

  

security

A weakness someone could use. Handled before anything else.

  

triage

Awaiting assessment

No labels

accepted

bug

declined

docs

duplicate

enhancement

good first issue

in-progress

needs-info

privacy

security

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

LibreKAT/Ocideck!524

No description provided.