brenno/Hiero
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Complete Q1–Q7 quality pass #26

Merged
brenno merged 1 commit from quality/q1-q7-improvements into main 2026-07-01 00:29:30 +00:00
Conversation 0 Commits 1 Files changed 88 +8880 -7490
brenno commented 2026-07-01 00:28:50 +00:00
Owner
Copy link

Summary

  • Q1 — Replace catch (_) in lib/data/ with appLog.fine diagnostics; extend regression test to enforce this.
  • Q2 — Regenerate aerodromes.dart so OurAirports website links are stored as HTTPS.
  • Q3 — Extend Forgejo CI with dart format --set-exit-if-changed and flutter test --coverage (lib/data summary).
  • Q4 — Split map_view.dart into core, marker/hover, and aircraft modules.
  • Q5 — Move about-screen markdown into assets/about/*.md with AboutMarkdownService.
  • Q6 — Add tests for bundled about markdown and HTTPS contact URL normalization.
  • Q7 — Split home_page.dart (widgets + aircraft list) and aip_sheets.dart (basic info panel).

Test plan

  • dart format --set-exit-if-changed lib test tool
  • flutter analyze (no errors)
  • flutter test (426 tests)
  • Open map view — markers, aircraft overlay, and hover METAR still work
  • Open aerodrome detail — contact website link and basic info panel render
  • About screen shows localized markdown in NL and EN
## Summary - **Q1** — Replace `catch (_)` in `lib/data/` with `appLog.fine` diagnostics; extend regression test to enforce this. - **Q2** — Regenerate `aerodromes.dart` so OurAirports website links are stored as HTTPS. - **Q3** — Extend Forgejo CI with `dart format --set-exit-if-changed` and `flutter test --coverage` (lib/data summary). - **Q4** — Split `map_view.dart` into core, marker/hover, and aircraft modules. - **Q5** — Move about-screen markdown into `assets/about/*.md` with `AboutMarkdownService`. - **Q6** — Add tests for bundled about markdown and HTTPS contact URL normalization. - **Q7** — Split `home_page.dart` (widgets + aircraft list) and `aip_sheets.dart` (basic info panel). ## Test plan - [x] `dart format --set-exit-if-changed lib test tool` - [x] `flutter analyze` (no errors) - [x] `flutter test` (426 tests) - [ ] Open map view — markers, aircraft overlay, and hover METAR still work - [ ] Open aerodrome detail — contact website link and basic info panel render - [ ] About screen shows localized markdown in NL and EN
Complete Q1–Q7 quality pass: logging, splits, assets, CI, and tests.
Some checks failed
Flutter CI / analyze-and-test (pull_request) Has been cancelled
Details
22a141a2be 
Log data-layer catch blocks instead of swallowing errors, regenerate aerodromes
with HTTPS website links, split large UI modules (map, home, AIP sheets), move
about markdown into bundled assets, extend CI with format/coverage checks, and
add regression tests for about content and contact URLs.

Co-authored-by: Cursor <cursoragent@cursor.com>
brenno merged commit 48aa6cd781 into main 2026-07-01 00:29:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
brenno/Hiero!26
No description provided.